Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double query #41

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fix double query #41

merged 1 commit into from
Nov 29, 2023

Conversation

kyle-sammons
Copy link
Collaborator

Summary

Right now we're making two queries to the KalDB backend. One for the histogram data, and one for the logging data. This PR combines that into a single query to reduce the load imposed on the backend and improve the frontend performance. In very unofficial and adhoc testing (via the Chrome Performance tool and multiple refreshes), this resulted in ~0.5 - 1 second improved load time.

Before:
image

After:
image

I also had to pin the yarn version due to this issue.

Resolves #38

Requirements (place an x in each [ ])

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

  • I've written tests to cover the new code and functionality included in this PR.

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

@kyle-sammons kyle-sammons force-pushed the ksammons-fix-double-query branch from 21ad2e2 to 79dd4b9 Compare November 29, 2023 19:06
@kyle-sammons kyle-sammons requested a review from bryanlb November 29, 2023 19:11
@kyle-sammons kyle-sammons merged commit 006ba0c into master Nov 29, 2023
2 checks passed
@kyle-sammons kyle-sammons deleted the ksammons-fix-double-query branch November 29, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine double query in custom UI for better performance
3 participants